Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jserv
force-pushed
the
fix
branch
2 times, most recently
from
026c82b to
a22e5d2
Compare
The in-process snapshot reads only the replay-target window's surface. Override-redirect shells (Qt popup menus and the like) render into their own borderless SDL windows, so a snapshot of a window with an open menu omits the menu, while a whole-screen capture (the system side's import) includes it. composeOverlayPopups() blits every mapped override-redirect top-level onto a copy of the target surface in stacking order before the BMP is written, so the single-window read matches a whole-screen capture. The copy uses SDL_CreateRGBSurfaceWithFormat plus a base blit rather than SDL_DuplicateSurface, which the older SDL2 on the differential runners does not export. Snapshots of popup-free windows are unaffected: the helper returns NULL and the target surface is saved unchanged.
Wire osiris-designer-menu.replay into both sides of the differential harness as a fifth demo: the system side drives it with xdotool, the compat side with the internal in-process backend and in-process snapshots. The replay opens the Designer File menu, which the popup compositing in the snapshot path captures on the compat side. Harden the run while adding load: replace the fixed post-Xvfb sleep with wait_for_display(), which polls xdotool getdisplaygeometry and bails if the Xvfb pid dies, and trap INT/TERM/HUP so the EXIT cleanup runs on signals. Bump system-side wait-window timeouts to 15000ms via awk so the real Xlib window has time to map on a loaded runner. Raise OSIRIS_DIFF_CHANGED_THRESHOLD to 0.55: the designer windows diverge 45-48% at the pixel level between real Xlib-Qt and libx11-compat-Qt (anti-aliasing, font subpixel), with designer-initial already at 0.45. The divergence is cosmetic, not a regression; the file-menu MAE is 0.056, far under the 0.16 MAE gate that stays the real fidelity bar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire the existing osiris-designer-menu.replay into both sides of the differential harness as a fifth demo. The system (xdotool) side gets its wait-window timeouts bumped to 15000ms via awk so the real Xlib window has time to map on a loaded runner; the compat side keeps the internal in-process backend and gains --in-process-snapshots.
Replace the fixed 'sleep 1' after Xvfb launch with wait_for_display(), which polls xdotool getdisplaygeometry and bails if the Xvfb pid dies, and trap INT TERM HUP so the EXIT cleanup runs on signals.
Summary by cubic
Adds the Osiris designer-menu replay to the differential harness and makes in-process snapshots include popup menus so diffs match the system side. Also hardens display startup and signal handling, and bumps the changed-ratio gate to 0.55 to avoid false diffs in the designer demos.
New Features
osiris-designer-menu.replayas the fifth demo on system (xdotool) and compat (internal).wait-windowto 15000ms viaawk; compat uses--in-process-snapshotswith the internal backend.Bug Fixes
Xvfbby pollingxdotool getdisplaygeometry; trap INT/TERM/HUP so EXIT cleanup runs.Written for commit 8b271b7. Summary will update on new commits.